Merge branch 'feature/update-9' of github.com:bergwerk/search_core into feature/update-9

# Conflicts:
#	Classes/Configuration/ConfigurationContainer.php
This commit is contained in:
Daniel Maier 2018-10-22 09:11:54 +02:00
commit 6a697133bb
4 changed files with 80 additions and 50 deletions

View file

@ -23,6 +23,7 @@ namespace Codappix\SearchCore\Configuration;
use TYPO3\CMS\Core\Utility\Exception\MissingArrayPathException; use TYPO3\CMS\Core\Utility\Exception\MissingArrayPathException;
use TYPO3\CMS\Extbase\Configuration\ConfigurationManagerInterface; use TYPO3\CMS\Extbase\Configuration\ConfigurationManagerInterface;
use TYPO3\CMS\Core\Utility\ArrayUtility; use TYPO3\CMS\Core\Utility\ArrayUtility;
use TYPO3\CMS\Extbase\Utility\DebuggerUtility;
/** /**
* Container of all configurations for extension. * Container of all configurations for extension.
@ -61,12 +62,9 @@ class ConfigurationContainer implements ConfigurationContainerInterface
*/ */
public function get(string $path) public function get(string $path)
{ {
try $value = ArrayUtility::getValueByPath($this->settings, $path, '.');
{
return ArrayUtility::getValueByPath($this->settings, $path); if ($value === null) {
}
catch (MissingArrayPathException $exception)
{
throw new InvalidArgumentException( throw new InvalidArgumentException(
'The given configuration option "' . $path . '" does not exist.', 'The given configuration option "' . $path . '" does not exist.',
InvalidArgumentException::OPTION_DOES_NOT_EXIST InvalidArgumentException::OPTION_DOES_NOT_EXIST
@ -82,7 +80,7 @@ class ConfigurationContainer implements ConfigurationContainerInterface
{ {
try try
{ {
return ArrayUtility::getValueByPath($this->settings, $path); return ArrayUtility::getValueByPath($this->settings, $path, '.');
} }
catch (\Exception $exception) catch (\Exception $exception)
{ {

View file

@ -1,4 +1,5 @@
<?php <?php
namespace Codappix\SearchCore\Domain\Index; namespace Codappix\SearchCore\Domain\Index;
/* /*
@ -23,6 +24,8 @@ namespace Codappix\SearchCore\Domain\Index;
use Codappix\SearchCore\Configuration\ConfigurationContainerInterface; use Codappix\SearchCore\Configuration\ConfigurationContainerInterface;
use Codappix\SearchCore\Configuration\InvalidArgumentException; use Codappix\SearchCore\Configuration\InvalidArgumentException;
use Codappix\SearchCore\Connection\ConnectionInterface; use Codappix\SearchCore\Connection\ConnectionInterface;
use TYPO3\CMS\Core\Exception;
use TYPO3\CMS\Core\Utility\Exception\MissingArrayPathException;
use TYPO3\CMS\Core\Utility\GeneralUtility; use TYPO3\CMS\Core\Utility\GeneralUtility;
abstract class AbstractIndexer implements IndexerInterface abstract class AbstractIndexer implements IndexerInterface
@ -125,28 +128,51 @@ abstract class AbstractIndexer implements IndexerInterface
} }
} }
/**
* @param array $record
*
* @throws \Exception
*/
protected function prepareRecord(array &$record) protected function prepareRecord(array &$record)
{ {
try { try {
foreach ($this->configuration->get('indexing.' . $this->identifier . '.dataProcessing') as $configuration) { $indexingConfiguration = $this->configuration->get('indexing.' . $this->identifier . '.dataProcessing');
$record = $this->dataProcessorService->executeDataProcessor($configuration, $record, $this->identifier);
if (!empty($indexingConfiguration) && is_array($indexingConfiguration)) {
foreach ($indexingConfiguration as $configuration) {
$record = $this->dataProcessorService->executeDataProcessor($configuration, $record,
$this->identifier);
}
}
} catch (\Exception $e) {
if ($e instanceof InvalidArgumentException) {
// Nothing to do
} elseif ($e instanceof MissingArrayPathException) {
// Nothing to do
} else {
throw $e;
} }
} catch (InvalidArgumentException $e) {
// Nothing to do.
} }
$this->handleAbstract($record); $this->handleAbstract($record);
} }
/**
* @param array $record
*
* @throws \Exception
*/
protected function handleAbstract(array &$record) protected function handleAbstract(array &$record)
{ {
$record['search_abstract'] = ''; $record['search_abstract'] = '';
try { try {
$fieldsToUse = GeneralUtility::trimExplode(
',', $indexConfiguration = $this->configuration->get('indexing.' . $this->identifier . '.abstractFields');
$this->configuration->get('indexing.' . $this->identifier . '.abstractFields')
); $fieldsToUse = GeneralUtility::trimExplode(',', $indexConfiguration);
if ($fieldsToUse === []) { if ($fieldsToUse === []) {
return; return;
} }
@ -156,8 +182,14 @@ abstract class AbstractIndexer implements IndexerInterface
break; break;
} }
} }
} catch (InvalidArgumentException $e) { } catch (\Exception $e) {
if ($e instanceof InvalidArgumentException) {
return; return;
} elseif ($e instanceof MissingArrayPathException) {
return;
} else {
throw $e;
}
} }
} }

View file

@ -18,8 +18,7 @@
"require": { "require": {
"php": ">=7.0.0", "php": ">=7.0.0",
"typo3/cms-core": ">= 7.6.0 < 10.0.0", "typo3/cms-core": ">= 7.6.0 < 10.0.0",
"ruflin/elastica": "~3.2", "ruflin/elastica": "~3.2"
"friendsoftypo3/typo3db-legacy": "^1.1.1"
}, },
"require-dev": { "require-dev": {
"phpunit/phpunit": "~6.4.4", "phpunit/phpunit": "~6.4.4",

View file

@ -42,12 +42,13 @@ call_user_func(
\Codappix\SearchCore\Compatibility\ImplementationRegistrationService::registerImplementations(); \Codappix\SearchCore\Compatibility\ImplementationRegistrationService::registerImplementations();
// API does make use of object manager, therefore use GLOBALS // API does make use of object manager, therefore use GLOBALS
$extensionConfiguration = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(\TYPO3\CMS\Core\Configuration\ExtensionConfiguration::class)->get($extensionKey); $extensionConfiguration = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(\TYPO3\CMS\Core\Configuration\ExtensionConfiguration::class)->get($extensionKey);
if ($extensionConfiguration === false if ($extensionConfiguration === false
|| !isset($extensionConfiguration['disable.']['elasticsearch']) || !isset($extensionConfiguration['disable']['elasticsearch'])
|| $extensionConfiguration['disable.']['elasticsearch'] !== '1' || $extensionConfiguration['disable']['elasticsearch'] !== '1'
) { ) {
\TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(\TYPO3\CMS\Extbase\Object\Container\Container::class) \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(\TYPO3\CMS\Extbase\Object\Container\Container::class)
->registerImplementation( ->registerImplementation(