From 379dddf8ac6f7e4bcb526f9f6627524398ecd5ff Mon Sep 17 00:00:00 2001 From: Daniel Siepmann Date: Wed, 8 Nov 2017 20:36:04 +0100 Subject: [PATCH] BUGFIX: Also remove fields containing "null" --- Classes/DataProcessing/RemoveProcessor.php | 2 +- Tests/Unit/DataProcessing/RemoveProcessorTest.php | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/Classes/DataProcessing/RemoveProcessor.php b/Classes/DataProcessing/RemoveProcessor.php index b5ab788..6e74237 100644 --- a/Classes/DataProcessing/RemoveProcessor.php +++ b/Classes/DataProcessing/RemoveProcessor.php @@ -34,7 +34,7 @@ class RemoveProcessor implements ProcessorInterface } foreach (GeneralUtility::trimExplode(',', $configuration['fields'], true) as $field) { - if (isset($record[$field])) { + if (array_key_exists($field, $record)) { unset($record[$field]); } } diff --git a/Tests/Unit/DataProcessing/RemoveProcessorTest.php b/Tests/Unit/DataProcessing/RemoveProcessorTest.php index 57600f0..dc55f73 100644 --- a/Tests/Unit/DataProcessing/RemoveProcessorTest.php +++ b/Tests/Unit/DataProcessing/RemoveProcessorTest.php @@ -117,6 +117,17 @@ class RemoveProcessorTest extends AbstractUnitTestCase 'field 1' => 'Some content like lorem', ], ], + 'Fields with "null" san be removed' => [ + 'record' => [ + 'field 1' => null, + ], + 'configuration' => [ + 'fields' => 'field 1', + '_typoScriptNodeValue' => 'Codappix\SearchCore\DataProcessing\RemoveProcessor', + ], + 'expectedRecord' => [ + ], + ], ]; } }