From 03a953c13f055a61d13bf4762ca8527dee64b53e Mon Sep 17 00:00:00 2001
From: Daniel Siepmann <coding@daniel-siepmann.de>
Date: Tue, 4 Jul 2017 10:27:03 +0200
Subject: [PATCH] TASK: Add unit test covering configuration option

Add test to cover option to configure user defined
additionalWhereClause.
---
 .../Index/TcaIndexer/TcaTableService.php      |  1 -
 .../Index/TcaIndexer/TcaTableServiceTest.php  | 96 +++++++++++++++++++
 2 files changed, 96 insertions(+), 1 deletion(-)
 create mode 100644 Tests/Unit/Domain/Index/TcaIndexer/TcaTableServiceTest.php

diff --git a/Classes/Domain/Index/TcaIndexer/TcaTableService.php b/Classes/Domain/Index/TcaIndexer/TcaTableService.php
index 7d69e5b..ae819bc 100644
--- a/Classes/Domain/Index/TcaIndexer/TcaTableService.php
+++ b/Classes/Domain/Index/TcaIndexer/TcaTableService.php
@@ -151,7 +151,6 @@ class TcaTableService
             . ' AND pages.no_search = 0'
             ;
 
-        // TODO: There is no test covering this option yet?
         $userDefinedWhere = $this->configuration->getIfExists('indexing.' . $this->getTableName() . '.additionalWhereClause');
         if (is_string($userDefinedWhere)) {
             $whereClause .= ' AND ' . $userDefinedWhere;
diff --git a/Tests/Unit/Domain/Index/TcaIndexer/TcaTableServiceTest.php b/Tests/Unit/Domain/Index/TcaIndexer/TcaTableServiceTest.php
new file mode 100644
index 0000000..3a5b7fd
--- /dev/null
+++ b/Tests/Unit/Domain/Index/TcaIndexer/TcaTableServiceTest.php
@@ -0,0 +1,96 @@
+<?php
+namespace Leonmrni\SearchCore\Tests\Unit\Domain\Index\TcaIndexer;
+
+/*
+ * Copyright (C) 2017  Daniel Siepmann <coding@daniel-siepmann.de>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+ * 02110-1301, USA.
+ */
+
+use Leonmrni\SearchCore\Configuration\ConfigurationContainerInterface;
+use Leonmrni\SearchCore\Domain\Index\TcaIndexer\TcaTableService;
+use Leonmrni\SearchCore\Tests\Unit\AbstractUnitTestCase;
+
+class TcaTableServiceTest extends AbstractUnitTestCase
+{
+    /**
+     * @var TcaTableService
+     */
+    protected $subject;
+
+    /**
+     * @var ConfigurationContainerInterface
+     */
+    protected $configuration;
+
+    public function setUp()
+    {
+        parent::setUp();
+
+        $this->configuration = $this->getMockBuilder(ConfigurationContainerInterface::class)->getMock();
+        $logger = $this->getMockBuilder(\TYPO3\CMS\Core\Log\LogManager::class)
+            ->disableOriginalConstructor()
+            ->setMethods(['getLogger'])
+            ->getMock();
+        $logger->expects($this->once())
+            ->method('getLogger')
+            ->will($this->returnValue(
+                $this->getMockBuilder(\TYPO3\CMS\Core\Log\Logger::class)
+                    ->disableOriginalConstructor()
+                    ->getMock()
+            ));
+
+        $this->subject = $this->getMockBuilder(TcaTableService::class)
+            ->disableOriginalConstructor()
+            ->setMethodsExcept(['getWhereClause', 'injectLogger', 'getTableName'])
+            ->getMock();
+        $this->inject($this->subject, 'configuration', $this->configuration);
+        $this->inject($this->subject, 'logger', $logger);
+        $this->inject($this->subject, 'tableName', 'table');
+    }
+
+    /**
+     * @test
+     */
+    public function doUsePlainQueryIfNoAdditionalWhereClauseIsDefined()
+    {
+        $this->configuration->expects($this->exactly(2))
+            ->method('getIfExists')
+            ->withConsecutive(['indexing.table.additionalWhereClause'], ['indexing.table.rootLineBlacklist'])
+            ->will($this->onConsecutiveCalls(null, false));
+
+        $this->assertSame(
+            '1=1 AND pages.no_search = 0',
+            $this->subject->getWhereClause()
+        );
+    }
+
+    /**
+     * @test
+     */
+    public function configuredAdditionalWhereClauseIsAdded()
+    {
+        $this->configuration->expects($this->exactly(2))
+            ->method('getIfExists')
+            ->withConsecutive(['indexing.table.additionalWhereClause'], ['indexing.table.rootLineBlacklist'])
+            ->will($this->onConsecutiveCalls('table.field = "someValue"', false));
+
+        $this->assertSame(
+            '1=1 AND pages.no_search = 0 AND table.field = "someValue"',
+            $this->subject->getWhereClause()
+        );
+    }
+}