2016-12-20 10:04:44 +01:00
|
|
|
.. highlight:: bash
|
|
|
|
|
2016-12-20 09:26:52 +01:00
|
|
|
.. _contribution:
|
|
|
|
|
|
|
|
Contribution
|
|
|
|
============
|
|
|
|
|
|
|
|
Everyone is welcome to contribute, whether it's code, issues, feature requests or any other kind.
|
|
|
|
|
|
|
|
Below is a documentation what to respect during contributions.
|
|
|
|
|
2016-12-20 10:04:44 +01:00
|
|
|
.. _contribution_setup:
|
|
|
|
|
|
|
|
Setup
|
|
|
|
-----
|
|
|
|
|
2016-12-22 09:45:43 +01:00
|
|
|
To start contributions regarding code, make sure your environment matches the following
|
|
|
|
requirements:
|
|
|
|
|
|
|
|
* composer is executable
|
|
|
|
|
|
|
|
* PHP on CLI is executable
|
|
|
|
|
|
|
|
* MySQL is up and running with user *dev* and password *dev* on *127.0.0.1* or to overwrite the
|
|
|
|
environment variables, see :file:`Makefile`.
|
|
|
|
And MySQL is not set to strict mode as TYPO3 doesn't support strict mode, see
|
|
|
|
https://review.typo3.org/#/c/26725/3/INSTALL.md.
|
|
|
|
|
|
|
|
* Elasticsearch is installed and up and running on *localhost:9200*.
|
|
|
|
|
|
|
|
Then setup your system::
|
2016-12-20 10:04:44 +01:00
|
|
|
|
|
|
|
git clone git@github.com:DanielSiepmann/search_core.git \
|
|
|
|
&& cd search_core \
|
2016-12-22 09:45:43 +01:00
|
|
|
&& export typo3DatabaseName="searchcoretest62" \
|
|
|
|
&& export TYPO3_VERSION="~6.2" \
|
2016-12-20 10:04:44 +01:00
|
|
|
&& make install \
|
|
|
|
&& make functionalTests
|
|
|
|
|
|
|
|
If all tests are okay, start your work.
|
|
|
|
|
2016-12-22 09:45:43 +01:00
|
|
|
If you are working with multiple TYPO3 versions make sure to export `typo3DatabaseName` and
|
|
|
|
`TYPO3_VERSION` in your environment like::
|
|
|
|
|
|
|
|
export typo3DatabaseName="searchcoretest76"
|
|
|
|
export TYPO3_VERSION="~7.6"
|
|
|
|
|
|
|
|
Also run the install command for each version before running any tests. Only this will make sure you
|
|
|
|
are testing against the actual TYPO3 Version and database scheme.
|
2016-12-20 10:04:44 +01:00
|
|
|
|
2016-12-20 09:26:52 +01:00
|
|
|
.. _contribution_development:
|
|
|
|
|
|
|
|
Development
|
|
|
|
-----------
|
|
|
|
|
|
|
|
All changes are introduced through pull requests at `Github`_ and should contain the following:
|
|
|
|
|
|
|
|
* Adjusted tests if tests existed before. Otherwise they will break on `travis-ci`_.
|
|
|
|
|
2016-12-22 09:45:43 +01:00
|
|
|
* New tests whenever possible and useful.
|
2016-12-20 09:26:52 +01:00
|
|
|
|
|
|
|
* Code has to follow `PSR-2`_.
|
|
|
|
|
|
|
|
* Adjusted documentation.
|
|
|
|
|
|
|
|
* Make sure to follow the documented :ref:`concepts`.
|
|
|
|
|
|
|
|
.. _Github: https://github.com/DanielSiepmann/search_core
|
|
|
|
.. _travis-ci: https://travis-ci.org/
|
|
|
|
.. _PSR-2: http://www.php-fig.org/psr/psr-2/
|