Improve TYPO3 cache handling #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielSiepmann
force-pushed
the
10500-fix-cache-handling
branch
from
bc639f6
to
3adc60e
Compare
DanielSiepmann
changed the title
DanielSiepmann
force-pushed
the
10500-fix-cache-handling
branch
2 times, most recently
from
9cd8098
to
521ce76
Compare
DanielSiepmann
commented
May 16, 2023
DanielSiepmann
force-pushed
the
10500-fix-cache-handling
branch
from
cb9dc80
to
30e3709
Compare
DanielSiepmann
force-pushed
the
10500-fix-cache-handling
branch
from
30e3709
to
1393a5e
Compare
There might be access to TSFE get_cache_timeout() prior rendering events. TYPO3 has a cache for timeout and won't re calculate again. We therefore need to clear the cache if timeout would change. That will lead to inconsistent cache information throughout a single request. But the final cache timeout of the page will be correct. Other parts might be longer, which probably is fine until they relate to the events. Relates: #10500
DanielSiepmann
force-pushed
the
10500-fix-cache-handling
branch
from
1393a5e
to
69433fa
Compare
justusmoroni
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There might be access to TSFE get_cache_timeout() prior rendering events.
TYPO3 has a cache for timeout and won't re calculate again. We therefore need to clear the cache if timeout would change.
That will lead to inconsistent cache information throughout a single request. But the final cache timeout of the page will be correct. Other parts might be longer, which probably is fine until they relate to the events.
Relates: #10500