Add features to build an archive #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
DanielSiepmann
commented
Jan 4, 2023
•
DanielSiepmann
commented
- Add context to factory
- Allow configuring default arguments if missing in request
- Add plugin name to AssignTemplateVariables event
The factory now accepts a context. That allows to build different data based on that context. The new feature is added in a backwards compatible way, just as an optional addition.
This provides huge flexibility as TypoScript can define the actual default. It no longer is hard coded into source code (still falling back to old defaults).
This allows listeners to react differently to different plugins.
DanielSiepmann
changed the title
DanielSiepmann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.