From c7ddbc4aef535deebe95c96566651bf655d64781 Mon Sep 17 00:00:00 2001 From: Daniel Siepmann Date: Tue, 9 May 2017 08:35:58 +0200 Subject: [PATCH] TASK: Finish removed extension test * Adjust expected result to match result. * Remove example usage of "use" as this is part of a feature and not this sniff. Relates: #44 --- .../Removed/ExtensionSniff/Expected.json | 19 ++++++++++++++----- .../ExtensionSniff/InputFileForIssues.php | 2 -- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/tests/Fixtures/Standards/Typo3Update/Sniffs/Removed/ExtensionSniff/Expected.json b/tests/Fixtures/Standards/Typo3Update/Sniffs/Removed/ExtensionSniff/Expected.json index 22c013b..a2cc1d7 100644 --- a/tests/Fixtures/Standards/Typo3Update/Sniffs/Removed/ExtensionSniff/Expected.json +++ b/tests/Fixtures/Standards/Typo3Update/Sniffs/Removed/ExtensionSniff/Expected.json @@ -4,21 +4,30 @@ "errors": 0, "messages": [ { - "column": 63, + "column": 53, "fixable": false, "line": 22, - "message": "Legacy extension are not allowed; found \"perm\"", + "message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html", "severity": 5, - "source": "Typo3Update.Removed.ExtensionKey.legacyKey", + "source": "Typo3Update.Removed.Extension.perm", + "type": "WARNING" + }, + { + "column": 53, + "fixable": false, + "line": 23, + "message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html", + "severity": 5, + "source": "Typo3Update.Removed.Extension.perm", "type": "WARNING" } ], - "warnings": 1 + "warnings": 2 } }, "totals": { "errors": 0, "fixable": 0, - "warnings": 1 + "warnings": 2 } } diff --git a/tests/Fixtures/Standards/Typo3Update/Sniffs/Removed/ExtensionSniff/InputFileForIssues.php b/tests/Fixtures/Standards/Typo3Update/Sniffs/Removed/ExtensionSniff/InputFileForIssues.php index 55f6cb2..c9039ad 100644 --- a/tests/Fixtures/Standards/Typo3Update/Sniffs/Removed/ExtensionSniff/InputFileForIssues.php +++ b/tests/Fixtures/Standards/Typo3Update/Sniffs/Removed/ExtensionSniff/InputFileForIssues.php @@ -19,7 +19,5 @@ * 02110-1301, USA. */ -use TYPO3\CMS\Perm\Controller\PermissionModuleController; - \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::isLoaded('perm'); \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::extRelPath('perm');