From 9b028d24e675c94fa617cee0fd97c68ec2c2db3d Mon Sep 17 00:00:00 2001 From: Daniel Siepmann Date: Tue, 9 May 2017 11:31:15 +0200 Subject: [PATCH] TASK: Update IsACallSniff tests to reflect added removed extension Relates: #44 --- .../Sniffs/Classname/IsACallSniff/Expected.diff | 3 ++- .../Sniffs/Classname/IsACallSniff/Expected.json | 13 +++++++++++-- .../Classname/IsACallSniff/InputFileForIssues.php | 3 +++ 3 files changed, 16 insertions(+), 3 deletions(-) diff --git a/tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/IsACallSniff/Expected.diff b/tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/IsACallSniff/Expected.diff index d099979..30d8556 100644 --- a/tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/IsACallSniff/Expected.diff +++ b/tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/IsACallSniff/Expected.diff @@ -1,6 +1,6 @@ --- tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/IsACallSniff/InputFileForIssues.php +++ PHP_CodeSniffer -@@ -23,15 +23,15 @@ +@@ -23,16 +23,16 @@ if (is_a($a, t3lib_Singleton::class)) { // do something } @@ -20,3 +20,4 @@ +if (is_a($a, "\\TYPO3\\CMS\\Core\\SingletonInterface")) { // do something } + if (is_a($a, "\\TYPO3\CMS\Perm\Controller\PermissionAjaxController")) { diff --git a/tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/IsACallSniff/Expected.json b/tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/IsACallSniff/Expected.json index 6795e14..ee399d9 100644 --- a/tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/IsACallSniff/Expected.json +++ b/tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/IsACallSniff/Expected.json @@ -38,14 +38,23 @@ "severity": 5, "source": "Typo3Update.Classname.IsACall.legacyClassname", "type": "ERROR" + }, + { + "column": 14, + "fixable": false, + "line": 38, + "message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html", + "severity": 5, + "source": "Typo3Update.Classname.IsACall.RemovedClass.perm", + "type": "WARNING" } ], - "warnings": 0 + "warnings": 1 } }, "totals": { "errors": 4, "fixable": 4, - "warnings": 0 + "warnings": 1 } } diff --git a/tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/IsACallSniff/InputFileForIssues.php b/tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/IsACallSniff/InputFileForIssues.php index 53a8a7b..cdcf3ba 100644 --- a/tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/IsACallSniff/InputFileForIssues.php +++ b/tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/IsACallSniff/InputFileForIssues.php @@ -35,3 +35,6 @@ if (is_a($a, "t3lib_Singleton")) { if (is_a($a, "\\t3lib_Singleton")) { // do something } +if (is_a($a, "\\TYPO3\CMS\Perm\Controller\PermissionAjaxController")) { + // do something +}