From 27864c70a1dc9f333c1af3d326f4499379df850e Mon Sep 17 00:00:00 2001
From: Daniel Siepmann <coding@daniel-siepmann.de>
Date: Tue, 9 May 2017 12:09:51 +0200
Subject: [PATCH] TASK: Update InstanceofSniff tests to reflect added removed
 extension

Relates: #44
---
 .../Classname/InstanceofSniff/Expected.diff   |  3 ++-
 .../Classname/InstanceofSniff/Expected.json   | 22 +++++++++++++++++--
 .../InstanceofSniff/InputFileForIssues.php    |  6 +++++
 3 files changed, 28 insertions(+), 3 deletions(-)

diff --git a/tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/InstanceofSniff/Expected.diff b/tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/InstanceofSniff/Expected.diff
index 49e34a3..43118c8 100644
--- a/tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/InstanceofSniff/Expected.diff
+++ b/tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/InstanceofSniff/Expected.diff
@@ -1,6 +1,6 @@
 --- tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/InstanceofSniff/InputFileForIssues.php
 +++ PHP_CodeSniffer
-@@ -19,6 +19,6 @@
+@@ -19,7 +19,7 @@
   * 02110-1301, USA.
   */
 
@@ -8,3 +8,4 @@
 +if ($a instanceof \TYPO3\CMS\Core\SingletonInterface) {
      // do something
  }
+ if ($a instanceof \TYPO3\CMS\Perm\Controller\PermissionAjaxController) {
diff --git a/tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/InstanceofSniff/Expected.json b/tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/InstanceofSniff/Expected.json
index 2cb2586..53b774e 100644
--- a/tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/InstanceofSniff/Expected.json
+++ b/tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/InstanceofSniff/Expected.json
@@ -11,14 +11,32 @@
                     "severity": 5,
                     "source": "Typo3Update.Classname.Instanceof.legacyClassname",
                     "type": "ERROR"
+                },
+                {
+                    "column": 20,
+                    "fixable": false,
+                    "line": 25,
+                    "message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html",
+                    "severity": 5,
+                    "source": "Typo3Update.Classname.Instanceof.RemovedExtension.perm",
+                    "type": "WARNING"
+                },
+                {
+                    "column": 19,
+                    "fixable": false,
+                    "line": 28,
+                    "message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html",
+                    "severity": 5,
+                    "source": "Typo3Update.Classname.Instanceof.RemovedExtension.perm",
+                    "type": "WARNING"
                 }
             ],
-            "warnings": 0
+            "warnings": 2
         }
     },
     "totals": {
         "errors": 1,
         "fixable": 1,
-        "warnings": 0
+        "warnings": 2
     }
 }
diff --git a/tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/InstanceofSniff/InputFileForIssues.php b/tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/InstanceofSniff/InputFileForIssues.php
index 8fe907f..96f6a76 100644
--- a/tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/InstanceofSniff/InputFileForIssues.php
+++ b/tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/InstanceofSniff/InputFileForIssues.php
@@ -22,3 +22,9 @@
 if ($a instanceof t3lib_Singleton) {
     // do something
 }
+if ($a instanceof \TYPO3\CMS\Perm\Controller\PermissionAjaxController) {
+    // do something
+}
+if ($a instanceof TYPO3\CMS\Perm\Controller\PermissionAjaxController) {
+    // do something
+}