2017-03-16 14:12:58 +01:00
|
|
|
<?php
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Copyright (C) 2017 Daniel Siepmann <coding@daniel-siepmann.de>
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU General Public License
|
|
|
|
* as published by the Free Software Foundation; either version 2
|
|
|
|
* of the License, or (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with this program; if not, write to the Free Software
|
|
|
|
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
|
|
|
|
* 02110-1301, USA.
|
|
|
|
*/
|
|
|
|
|
2017-03-23 10:23:45 +01:00
|
|
|
use PHP_CodeSniffer_File as PhpCsFile;
|
2017-03-16 14:12:58 +01:00
|
|
|
use PHP_CodeSniffer_Tokens as Tokens;
|
2017-03-23 10:23:45 +01:00
|
|
|
use Typo3Update\Sniffs\LegacyClassnames\AbstractClassnameChecker;
|
2017-03-16 14:12:58 +01:00
|
|
|
|
|
|
|
/**
|
2017-03-16 15:18:10 +01:00
|
|
|
* Detect and migrate old legacy classname instantiations using objectmanager create and get.
|
2017-03-16 14:12:58 +01:00
|
|
|
*/
|
2017-03-23 10:23:45 +01:00
|
|
|
class Typo3Update_Sniffs_LegacyClassnames_InstantiationWithObjectManagerSniff extends AbstractClassnameChecker
|
2017-03-16 14:12:58 +01:00
|
|
|
{
|
|
|
|
use \Typo3Update\Sniffs\ExtendedPhpCsSupportTrait;
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Returns the token types that this sniff is interested in.
|
|
|
|
*
|
|
|
|
* @return array<int>
|
|
|
|
*/
|
|
|
|
public function register()
|
|
|
|
{
|
|
|
|
return Tokens::$functionNameTokens;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Processes the tokens that this sniff is interested in.
|
|
|
|
*
|
2017-03-23 10:23:45 +01:00
|
|
|
* @param PhpCsFile $phpcsFile The file where the token was found.
|
2017-03-16 14:12:58 +01:00
|
|
|
* @param int $stackPtr The position in the stack where
|
|
|
|
* the token was found.
|
|
|
|
*
|
|
|
|
* @return void
|
|
|
|
*/
|
2017-03-23 10:23:45 +01:00
|
|
|
public function process(PhpCsFile $phpcsFile, $stackPtr)
|
2017-03-16 14:12:58 +01:00
|
|
|
{
|
|
|
|
if (!$this->isFunctionCall($phpcsFile, $stackPtr)) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
$tokens = $phpcsFile->getTokens();
|
|
|
|
|
|
|
|
$functionName = $tokens[$stackPtr]['content'];
|
|
|
|
if (!in_array($functionName, ['get', 'create'])) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
$classnamePosition = $phpcsFile->findNext(T_CONSTANT_ENCAPSED_STRING, $stackPtr);
|
|
|
|
if ($classnamePosition === false) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if ($functionName === 'create') {
|
|
|
|
$phpcsFile->addWarning(
|
|
|
|
'The "create" method of ObjectManager is no longer supported, please migrate to "get".',
|
|
|
|
$stackPtr,
|
|
|
|
'mightBeDeprecatedMethod',
|
|
|
|
['create']
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2017-03-21 08:59:26 +01:00
|
|
|
$classname = $tokens[$classnamePosition]['content'];
|
2017-03-16 14:12:58 +01:00
|
|
|
$this->originalTokenContent = $tokens[$classnamePosition]['content'];
|
|
|
|
$this->addFixableError($phpcsFile, $classnamePosition, $classname);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* As token contains more then just class name, we have to build new content ourself.
|
|
|
|
*
|
|
|
|
* @param string $classname
|
|
|
|
* @return string
|
|
|
|
*/
|
|
|
|
protected function getTokenForReplacement($classname)
|
|
|
|
{
|
2017-03-21 08:59:26 +01:00
|
|
|
return $this->getTokenReplacementForString($classname);
|
2017-03-16 14:12:58 +01:00
|
|
|
}
|
|
|
|
}
|