From 1c8c07954f890137fd92bf49a2d1af9a531e38f9 Mon Sep 17 00:00:00 2001 From: Florian Weiss Date: Wed, 20 May 2020 16:25:48 +0200 Subject: [PATCH] [FIX] Return ResponseInterface after issuing verification instead of direct output --- .../AutoGrantBusinessVerification.php | 2 +- src/Verification/Issuer.php | 9 +++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/Example/FullSettingsRequired/AutoGrantBusinessVerification.php b/src/Example/FullSettingsRequired/AutoGrantBusinessVerification.php index 59a170b..9ba59da 100644 --- a/src/Example/FullSettingsRequired/AutoGrantBusinessVerification.php +++ b/src/Example/FullSettingsRequired/AutoGrantBusinessVerification.php @@ -11,4 +11,4 @@ use SkillDisplay\PHPToolKit\Verification\Issuer; // In order to grant an Educational Verification you just need to exchange the constant to VERIFICATION_EDUCATIONAL // (your Verifier Account needs the according permissions) $myVerificationTool = new Issuer($mySettings); -$myVerificationTool->issueVerification(193,'--skilldisplay-user-email--', VERIFICATION_BUSINESS); \ No newline at end of file +$myVerificationTool->outputResponse($myVerificationTool->issueVerification(193,'--skilldisplay-user-email--', VERIFICATION_BUSINESS)); \ No newline at end of file diff --git a/src/Verification/Issuer.php b/src/Verification/Issuer.php index d2c0ed1..6e431f1 100644 --- a/src/Verification/Issuer.php +++ b/src/Verification/Issuer.php @@ -38,7 +38,7 @@ class Issuer { * * Outputs a response of a request directly on the page */ - private function outputResponse(ResponseInterface $response){ + public function outputResponse(ResponseInterface $response){ // Get all of the response headers. foreach ($response->getHeaders() as $name => $values) { echo $name . ': ' . implode(', ', $values) . "\r\n"; @@ -51,8 +51,9 @@ class Issuer { * @param int $skillID SkillID of the skill for which the verification should be issued (can be read from URL after a search - eg.: https://my.dev.skilldisplay.eu/skill/4/0 has ID 4) * @param string $useremail E-Mail of the SkillDisplay user for whom you want to verify the skill * @param string $vtype Verification type, one of the constants in /src/Constants/VerificationTypes.php + * @return ResponseInterface */ - public function issueVerification(int $skillID, string $useremail, string $vtype){ + public function issueVerification(int $skillID, string $useremail, string $vtype) : ResponseInterface { $requestData = $this->generateSignedRequestData($skillID, $useremail, $vtype); $client = new \GuzzleHttp\Client(); @@ -66,8 +67,8 @@ class Issuer { json_encode($requestData) ); - $response = $client->send($request); - $this->outputResponse($response); + return $client->send($request); + } /**